test: internalize external documents #2109
Conversation
…nsys/pyansys-geometry into test/internalize_external_docs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -535,3 +535,32 @@ def test_design_insert_id_bug(modeler: Modeler): | |||
|
|
|||
| assert len(design1.components[0].bodies) == 1 | |||
| assert len(design1.components[1].bodies) == 1 | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="Object reference not set to an instance of an object.") | |||
There was a problem hiding this comment.
@RobPasMue I am skipping this test until we can fix the server side error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 93.66% 93.64% -0.02%
==========================================
Files 138 138
Lines 10156 10156
==========================================
- Hits 9513 9511 -2
- Misses 643 645 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -125,7 +125,27 @@ def test_docker_not_available(monkeypatch): | |||
| # Replace the launch_docker_modeler function with a dummy function | |||
| monkeypatch.setattr( | |||
| "ansys.geometry.core.connection.launcher.launch_docker_modeler", | |||
| dummy_launch_docker_modeler, | |||
| lambda **kwargs: (_ for _ in ()).throw(NotImplementedError("Docker not available")), | |||
There was a problem hiding this comment.
This change should avoid anything from trying to launch
| assert _is_port_available(available_port, host) is True | ||
|
|
||
| # Test an unavailable port by binding it | ||
| unavailable_port = 5001 | ||
| unavailable_port = find_available_port() | ||
| with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s: | ||
| s.bind((host, unavailable_port)) # Bind the port to make it unavailable |
There was a problem hiding this comment.
One of our pipelines had this test fail due to "PermissionError: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions"
| @pytest.mark.parametrize( | ||
| "port, should_raise, expected_message", | ||
| [ | ||
| (5000, False, None), # Test for an available port |
There was a problem hiding this comment.
Same pipeline error as above: PermissionError: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions
Description
Verify that external docs are internalized. Skipping due to server side issue
Fix some newly added tests to be more stable
Checklist
feat: extrude circle to cylinder)